Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add periodic cgroup fingerprinter #712

Merged
merged 4 commits into from
Jan 29, 2016

Conversation

iverberk
Copy link
Contributor

Periodically check for the availability of cgroups. Disable the exec driver if cgroups are not available.

Make the exec driver fingerprinter periodic to disable the driver when
cgroups become unavailable.
@@ -41,6 +43,7 @@ var builtinFingerprintMap = map[string]Factory{
}

// NewFingerprint is used to instantiate and return a new fingerprint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental new line?

@dadgar
Copy link
Contributor

dadgar commented Jan 27, 2016

LGTM. Minor comments!

@@ -60,6 +58,10 @@ func (d *ExecDriver) Fingerprint(cfg *config.Config, node *structs.Node) (bool,
return true, nil
}

func (d *ExecDriver) Periodic() (bool, time.Duration) {
return true, 15 * time.Second
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract 15 in a constant.

@dadgar
Copy link
Contributor

dadgar commented Jan 29, 2016

Awesome! Thanks Ivo!

dadgar added a commit that referenced this pull request Jan 29, 2016
@dadgar dadgar merged commit df22fca into hashicorp:master Jan 29, 2016
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants